Review Request: Add warning for searching the complete file system

Andre Heinecke aheinecke at intevation.de
Wed May 2 20:50:51 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104826/
-----------------------------------------------------------

Review request for KDE Base Apps.


Description
-------

In my company it regularly happens that some "non technical" person, e.g. a secretary or a marketing guy tries to find a file he or she has no idea where it is placed.
When they use kfind to search the complete file system without using locate this pretty much means a DOS attack on our company network with loads of NFS shares etc.

Searching the complete filesystem is nearly always wrong but as users are used to it from "Search my Computer" or other indexed search options they might not realize it.

This Patch adds a confirmation dialog if you want to search / or file:/// recursively without using locate warning you that this might take a very long time and is a resource intensive operation


Diffs
-----

  kfind/kfinddlg.cpp 12b3b7e 
  kfind/kquery.h 39609f3 

Diff: http://git.reviewboard.kde.org/r/104826/diff/


Testing
-------

Compiled, tested with regular paths, as well as / and file:///


Thanks,

Andre Heinecke

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120502/8e287c42/attachment.htm>


More information about the kde-core-devel mailing list