Review Request: make folderview icons translucent if composite is enabled

[Hugo Pereira Da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101463/#review13308
-----------------------------------------------------------


For the record, I have implemented a 'modified' version of Thomas patch in oxygen (without the "clearMask()" call that could possibly break things elsewhere), and it just works (without this current patch implemented).
See: http://wstaw.org/m/2012/05/03/dnd0.png

This is pushed to master. I do not think it requires backporting to KDE 4.8

(As a side note, I have also implemented alpha channel for Window tabbing dnd icons, in oxygen-decoration, to test the above. See: http://wstaw.org/m/2012/05/03/dnd1.png)

I believe this review request can therefore be discarder.


- Hugo Pereira Da Costa


On April 19, 2012, 11:29 p.m., Mathias Stephan Panzenböck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101463/
> -----------------------------------------------------------
> 
> (Updated April 19, 2012, 11:29 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> This patch makes dragged folderview icons translucent if composite is enabled. It is a kinda hack that uses an event filter to find Qt's D'n'D window, clears any mask on it and sets the Qt::WA_TranslucentBackground attribute. I use it day to day and it works fine.
> 
> The proper place to fix this would be in Qt, but they wrongfully marked the bug report as invalid, because they think X11 does not support translucent windows:
> http://bugreports.qt.nokia.com/browse/QTBUG-8519
> 
> 
> This addresses bug 256475.
>     http://bugs.kde.org/show_bug.cgi?id=256475
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/iconview.h e648ff0 
>   plasma/applets/folderview/iconview.cpp 3186b18 
> 
> Diff: http://git.reviewboard.kde.org/r/101463/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mathias Stephan Panzenböck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120503/8a97aba7/attachment.htm>