Review Request: Fix Solid CMake check with Qt 5

[Stephen Kelly]

> On May 2, 2012, 11:43 a.m., Stephen Kelly wrote:
> > Please do not submit this. It is out of date. You are probably using qt5.git which is way out of date. This is not needed anymore.
> 
> Alexander Richardson wrote:
>     Ok. How do I get a Qt 5 with which I can build kdelibs? Checkout master in every repo?

I'm not familiar with the script you are using or with qt5.git.

If you have qtbase.git and qtsvg.git  (master) that's enough to build most of frameworks. I don't know if that would break your script and cause you to need to update the rest too.


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104820/#review13267
-----------------------------------------------------------


On May 1, 2012, 11:28 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104820/
> -----------------------------------------------------------
> 
> (Updated May 1, 2012, 11:28 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Fix CMake configure with Qt 5
> DBusTools is required so that qt5_add_dbus_interfaces is available
> 
> Not sure if this is the preferred way of solving the issue, but it works for me.
> 
> 
> Diffs
> -----
> 
>   tier1/solid/src/solid/CMakeLists.txt f309a64 
> 
> Diff: http://git.reviewboard.kde.org/r/104820/diff/
> 
> 
> Testing
> -------
> 
> Configuring didn't work before, now it does.
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120502/dbb18f51/attachment.htm>