Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

[Michael Jansen]

On Tuesday, May 01, 2012 06:05:01 PM Mark Gaiser wrote:


This is an automatically generated e-mail. To reply, visit: 
http://git.reviewboard.kde.org/r/104801/ 


On April 30th, 2012, 10:19 p.m., David Faure wrote: 
I am in favour of the idea, since I was hit by this limitation in the past, 
too.
However I think the API changes should be more conservative, there's no need 
to deprecate so many of the existing methods, just because it is *possible* to 
define more than 2 shortcuts.

Also, Qt's QAction already has void QAction::setShortcuts(const 
QList<QKeySequence> &shortcuts)... remind me why we are not using that? 
Because it doesn't know "default shortcut" vs "current shortcut"? 
I would love to remind you, but i simply don't know. I took it for granted 
since the current documentation talks about it. The doc above 
http://quickgit.kde.org/index.php?p=kdelibs.git&a=blob&h=d87755435e9131767e63311a8b3edc34adbf87ce&hb=dc217720bd685a30ef7914f09ab8c1e321b92c88&f=kdeui%2Factions%2Fkaction.h 
(line 316)

Most likely because it says since Qt 4.2 in the docs and KAction was done 
before that?

Before my time too.

Mike
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120501/c8f737b1/attachment.htm>