Review Request: kdepasswd KCM: fixed freeze when changing user name

[Sergey Borovkov]

> On March 31, 2012, 8:08 p.m., Raphael Kubo da Costa wrote:
> > Could you detail a bit more what was wrong with the way the output is/was being parsed?
> 
> Sergey Borovkov wrote:
>     I'll post it in few hours, sorry for not posting it when I made review request

So the bug was that "Changing finger info" was output before "Password" line, so what happened was - first readLine() got "Changing finger info" and we went straight to second readLine() that read "Password". After that it was stuck in infinite loop on line 57 because we were getting empty line every time.
Strange thing is that after testing chfn on different distros I got some different - for example after wrong password is supplied to chfn in Mandriva it outputs "Authorization failure" that's not even checked in the code. So may be this issue still requires some additional research. If you have any ideas please tell me I will gladly do it.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104439/#review12073
-----------------------------------------------------------


On March 31, 2012, 8:16 p.m., Sergey Borovkov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104439/
> -----------------------------------------------------------
> 
> (Updated March 31, 2012, 8:16 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> Very simple patch that fixes Bug 156396. On some systems loop was just going forever because of the way parsing chfn output was written.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=156396.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=156396
> 
> 
> Diffs
> -----
> 
>   kdepasswd/kcm/chfnprocess.cpp 9f75d4a 
> 
> Diff: http://git.reviewboard.kde.org/r/104439/diff/
> 
> 
> Testing
> -------
> 
> Tested it on Mandriva 2011 and Suse 12.2 with KDE 4.8.1
> 
> 
> Thanks,
> 
> Sergey Borovkov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120331/f1abe16e/attachment.htm>