Review Request: Copy files instead of moving if parent dir is not writable

Lamarque Vieira Souza lamarque at kde.org
Fri Mar 30 21:40:15 BST 2012



> On March 30, 2012, 8:18 p.m., Thomas L├╝bking wrote:
> > service/jobs/nepomuk/Move.cpp, line 352
> > <http://git.reviewboard.kde.org/r/104417/diff/5/?file=55320#file55320line352>
> >
> >     "!QUrl::isLocalFile()"?

isLocalFile() was introduced in Qt 4.8.0 and we still use Qt 4.7.4 in Meego image.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104417/#review12037
-----------------------------------------------------------


On March 30, 2012, 6:57 p.m., Lamarque Vieira Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104417/
> -----------------------------------------------------------
> 
> (Updated March 30, 2012, 6:57 p.m.)
> 
> 
> Review request for KDE Runtime and Plasma.
> 
> 
> Description
> -------
> 
> When adding an application resource to a private activity kactivitymanager tries to move the resource's .desktop file to the activity's private folder. The new .desktop file is created successfully but the source file is not deleted if the user does not have write permission on the file's directory. This patch detects such situation and uses copy instead of move to prevent "permission denied" messages for every resource being added.
> 
> 
> This addresses bug 296808.
>     http://bugs.kde.org/show_bug.cgi?id=296808
> 
> 
> Diffs
> -----
> 
>   service/jobs/nepomuk/Move.h 8a8afd1 
>   service/jobs/nepomuk/Move.cpp 2248768 
> 
> Diff: http://git.reviewboard.kde.org/r/104417/diff/
> 
> 
> Testing
> -------
> 
> Works for resources of type "app", it does not work for "image" yet because Move::canMove receives the nepomuk's uri instead of the file url when the resource type is "image".
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120330/d77d49f1/attachment.htm>


More information about the kde-core-devel mailing list