Review Request: Copy files instead of moving if parent dir is not writable

Lamarque Vieira Souza lamarque at
Fri Mar 30 19:57:43 BST 2012

This is an automatically generated e-mail. To reply, visit:

(Updated March 30, 2012, 6:57 p.m.)

Review request for KDE Runtime and Plasma.


Fix the code that moves files and make it create sub-folders for each file being moved so that files with the same name but different parent folder do not clash.


When adding an application resource to a private activity kactivitymanager tries to move the resource's .desktop file to the activity's private folder. The new .desktop file is created successfully but the source file is not deleted if the user does not have write permission on the file's directory. This patch detects such situation and uses copy instead of move to prevent "permission denied" messages for every resource being added.

This addresses bug 296808.

Diffs (updated)

  service/jobs/nepomuk/Move.h 8a8afd1 
  service/jobs/nepomuk/Move.cpp 2248768 



Works for resources of type "app", it does not work for "image" yet because Move::canMove receives the nepomuk's uri instead of the file url when the resource type is "image".


Lamarque Vieira Souza

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list