Review Request: Remember current desktop when changing activity

[Ingo Klöcker]

> On March 21, 2012, 6:29 p.m., Ivan Čukić wrote:
> > Ship It!
> 
> makis marimpis wrote:
>     please forgive my ignorance, but should i close it as submitted or wait? :-)

You should have committed it with the REVIEW keyword. See http://techbase.kde.org/Policies/SVN_Commit_Policy#Special_keywords_in_SVN_log_messages which also applies to Git.


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104261/#review11705
-----------------------------------------------------------


On March 18, 2012, 9:22 a.m., makis marimpis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104261/
> -----------------------------------------------------------
> 
> (Updated March 18, 2012, 9:22 a.m.)
> 
> 
> Review request for KDE Runtime and Plasma.
> 
> 
> Description
> -------
> 
> Patches kactivitymanagerd to store (and restore back) the working current directory when switching activities.
> 
> The activity-changing-behavior is as follows:
> 1.  Say you have two (or more activities) A and B.
> 2.  You are working on activity A on Desktop 4.
> 3.  You switch to activity B (and by default to Desktop 4).
> 4.  Change to Desktop 1.
> 5.  Go back to activity A and (by default) to Desktop 1, while it should move you to Desktop 4 (this is where my patch kicks in).
> 
> I hope it makes sense :-)
> 
> 
> This addresses bugs 241864 and 265015.
>     http://bugs.kde.org/show_bug.cgi?id=241864
>     http://bugs.kde.org/show_bug.cgi?id=265015
> 
> 
> Diffs
> -----
> 
>   service/ActivityManager_p.h d054eb7 
>   service/ActivityManager.cpp 7af2049 
> 
> Diff: http://git.reviewboard.kde.org/r/104261/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> makis marimpis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120329/45113910/attachment.htm>