Review Request: KJS: Extend strictEqual check for numbers by NaN and signbit check
Bernd Buschinski
b.buschinski at googlemail.com
Thu Mar 22 00:41:49 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104358/
-----------------------------------------------------------
(Updated March 22, 2012, 12:41 a.m.)
Review request for kdelibs.
Changes
-------
Whoops sorry, wrong/old version uploaded
- now really check for NaN using isNan
Description
-------
In c++ NAN == NAN return false, true in javascript 9.12 Step 4.a
also +0 == -0 is true in c++, false in javascript 9.12 Step 4.b (same for -0 == +0 , Step 4c)
Diffs (updated)
-----
kjs/operations.cpp d4c0066
Diff: http://git.reviewboard.kde.org/r/104358/diff/
Testing
-------
Tesed via ecmascript, fixes some tests that rely on +0 not beeing the same as -0
Thanks,
Bernd Buschinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120322/aa1434f2/attachment.htm>
More information about the kde-core-devel
mailing list