Review Request: KJS/Grammar: Introduce new non-terminal IdentifierName, to handle keywords as PropertyName, in Memberexps and CallExpr

[Bernd Buschinski]

> On March 20, 2012, 9:30 p.m., Maks Orlovich wrote:
> > Can I presume this change doesn't changer # of conflicts?
> >

I don't understand what conflicts you mean. If you mean failing tests in ecmascript262, it does change the number, it recudes the fails by ~50


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104243/#review11664
-----------------------------------------------------------


On March 12, 2012, 9:03 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104243/
> -----------------------------------------------------------
> 
> (Updated March 12, 2012, 9:03 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> KJS/Grammar: Introduce new non-terminal IdentifierName,
> which allows keywords to be used as PropertyName, in Memberexps and CallExpr.
> (but not yet enum,export,extends, super, because they have the same value RESERVED)
> 
> 
> Diffs
> -----
> 
>   kjs/grammar.h 2a006df 
>   kjs/grammar.cpp 32dbeae 
>   kjs/grammar.y d5e835f 
> 
> Diff: http://git.reviewboard.kde.org/r/104243/diff/
> 
> 
> Testing
> -------
> 
> Tested with ecmascript262, all keyword cases pass now, except the reserved ones
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120322/0a4ecd12/attachment.htm>