Review Request: Remember current desktop when changing activity

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104261/#review11373
-----------------------------------------------------------



service/ActivityManager.cpp
<http://git.reviewboard.kde.org/r/104261/#comment9100>

    remove trailing whitespace.
    
    You should also save the desktop id in disk so that on next reboot kamd sets the currect desktop id. Just do
    
    mainConfig().writeEntry("currentDesktop", desktopId);
    
    here and read the value in ActivityManager::ActivityManager().



service/ActivityManager.cpp
<http://git.reviewboard.kde.org/r/104261/#comment9099>

    remove trailing whitespace.



service/ActivityManager.cpp
<http://git.reviewboard.kde.org/r/104261/#comment9101>

    remove trailing whitespace.



service/ActivityManager.cpp
<http://git.reviewboard.kde.org/r/104261/#comment9102>

    remove trailing whitespace.


- Lamarque Vieira Souza


On March 13, 2012, 6:53 p.m., makis marimpis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104261/
> -----------------------------------------------------------
> 
> (Updated March 13, 2012, 6:53 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Patches kactivitymanagerd to store (and restore back) the working current directory when switching activities.
> 
> The activity-changing-behavior is as follows:
> 1.  Say you have two (or more activities) A and B.
> 2.  You are working on activity A on Desktop 4.
> 3.  You switch to activity B (and by default to Desktop 4).
> 4.  Change to Desktop 1.
> 5.  Go back to activity A and (by default) to Desktop 1, while it should move you to Desktop 4 (this is where my patch kicks in).
> 
> I hope it makes sense :-)
> 
> 
> This addresses bugs 241864 and 265015.
>     http://bugs.kde.org/show_bug.cgi?id=241864
>     http://bugs.kde.org/show_bug.cgi?id=265015
> 
> 
> Diffs
> -----
> 
>   service/ActivityManager.cpp 7af2049 
>   service/ActivityManager_p.h d054eb7 
> 
> Diff: http://git.reviewboard.kde.org/r/104261/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> makis marimpis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120313/a21a6b84/attachment.htm>