Review Request: KJS: Implement Object.GetPrototypeOf, Object.GetOwnPropertyDescriptor, Object.DefineProperty

Bernd Buschinski b.buschinski at googlemail.com
Mon Mar 12 21:08:49 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104244/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

KJS: Implement Object.GetPrototypeOf, Object.GetOwnPropertyDescriptor, Object.DefineProperty

With this ECMAScript is down to 2855 fails.
The remaining DefineProperty fails are because of Array&String need
some special implementation for that(according to ecma), also because of currently not implemented Extensible.
In combination with a function prototype it also fails, but that is a bug somewhere else.

New PropertyDescriptor collects and manages proptery attributes according to ecma.


Diffs
-----

  kjs/CMakeLists.txt 1188064 
  kjs/CommonIdentifiers.h 8ee40e8 
  kjs/object.h 047c242 
  kjs/object.cpp c19122f 
  kjs/object_object.cpp 986f03f 
  kjs/propertydescriptor.h PRE-CREATION 
  kjs/propertydescriptor.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/104244/diff/


Testing
-------

Tested with ecmascript262, reduces fails to 2855, about 2000 fails less than without this patch.


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120312/00070963/attachment.htm>


More information about the kde-core-devel mailing list