Review Request: Make sure there is a whitespace after the colon in Content-Type header line

Andrea Iacovitti aiacovitti at libero.it
Sun Mar 11 20:49:03 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104221/
-----------------------------------------------------------

(Updated March 11, 2012, 8:49 p.m.)


Review request for kdelibs, Dawit Alemayehu and David Faure.


Changes
-------

removed the trimmed() statement


Description
-------

Make sure there is a whitespace after the colon in Content-Type header line.
This is not mandatory as of RFC 2616 but it could cause problem on some http server (bug 295305).


This addresses bug 295305.
    http://bugs.kde.org/show_bug.cgi?id=295305


Diffs (updated)
-----

  kioslave/http/http.cpp 40d10e2 

Diff: http://git.reviewboard.kde.org/r/104221/diff/


Testing
-------

Using WebKit engine in konqueror the value of content-type metaData is set to "application/x-www-form-urlencoded"
ending up to the following content-type http header line sent to the server "Content-Type:application/x-www-form-urlencoded"
(so i suppose the bug reporter was using WebKit engine)

The problem doesn't affect KHTML engine that sets content-type metadaData to "Content-type: application/x-www-form-urlencoded"


Thanks,

Andrea Iacovitti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120311/e716eb16/attachment.htm>


More information about the kde-core-devel mailing list