Review Request: Make sure there is a whitespace after the colon in Content-Type header line

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104221/#review11294
-----------------------------------------------------------


Oops. I meant provide a review. I rather you do not include the .trimmed() statement for now because I am not entirely sure something else might now break. Just adding the white space after "Content-Type"  should be enough to fix the stated bug.

- Dawit Alemayehu


On March 11, 2012, 11:37 a.m., Andrea Iacovitti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104221/
> -----------------------------------------------------------
> 
> (Updated March 11, 2012, 11:37 a.m.)
> 
> 
> Review request for kdelibs, Dawit Alemayehu and David Faure.
> 
> 
> Description
> -------
> 
> Make sure there is a whitespace after the colon in Content-Type header line.
> This is not mandatory as of RFC 2616 but it could cause problem on some http server (bug 295305).
> 
> 
> This addresses bug 295305.
>     http://bugs.kde.org/show_bug.cgi?id=295305
> 
> 
> Diffs
> -----
> 
>   kioslave/http/http.cpp 40d10e2 
> 
> Diff: http://git.reviewboard.kde.org/r/104221/diff/
> 
> 
> Testing
> -------
> 
> Using WebKit engine in konqueror the value of content-type metaData is set to "application/x-www-form-urlencoded"
> ending up to the following content-type http header line sent to the server "Content-Type:application/x-www-form-urlencoded"
> (so i suppose the bug reporter was using WebKit engine)
> 
> The problem doesn't affect KHTML engine that sets content-type metadaData to "Content-type: application/x-www-form-urlencoded"
> 
> 
> Thanks,
> 
> Andrea Iacovitti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120311/46d002ef/attachment.htm>