Review Request: Add Javascript policy related settings to newly added HtmlSettingsInterface class

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104179/#review11279
-----------------------------------------------------------

Ship it!


Looks good, just one question.


kparts/htmlextension.cpp
<http://git.reviewboard.kde.org/r/104179/#comment9036>

    Any idea why this uses I18N_NOOP? Is this so that the untranslated string gets used in config files, but the GUI code can call i18n() on it for display purposes?
    If this is indeed used like that, please document it, otherwise remove I18N_NOOP.


- David Faure


On March 10, 2012, 3:39 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104179/
> -----------------------------------------------------------
> 
> (Updated March 10, 2012, 3:39 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> The attached patch adds several JavaScript policy and setting related enums and three convenience functions to KParts::HtmlSettingsInterface so that they can be shared by all browser engines (kwebkitpart and khtml) and the Konqueror html kcm. Currently these enums and convenience functions are duplicated in the two browser engines. The Konqueror html kcm simply uses the one from the khtml browser engine because it publicly exports those values. Unfortunately that means the html kcm has to directly link against the khtml engine resulting in it being loaded into memory when the Konqueror configuration dialog is launched even regardless of what browser engine is used as the default. This patch is the first step in removing that dependency so that khtml is not loaded when webkit is used as the default browser engine.
> 
> 
> Diffs
> -----
> 
>   khtml/khtml_ext.cpp 3a1da4a 
>   kparts/htmlextension.h b91f203 
>   kparts/htmlextension.cpp 761c42c 
> 
> Diff: http://git.reviewboard.kde.org/r/104179/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120311/d1ff406e/attachment.htm>