Review Request: Add recentdocuments:/ kio slave to kde-runtime.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103849/#review11278
-----------------------------------------------------------

Ship it!


Looks good, please commit after adjusting the last minor issues I found below.


kioslave/recentdocuments/recentdocuments.cpp
<http://git.reviewboard.kde.org/r/103849/#comment9033>

    The method name is already printed by kDebug().



kioslave/recentdocuments/recentdocuments.cpp
<http://git.reviewboard.kde.org/r/103849/#comment9034>

    This should be url.toLocalFile() rather than url.path() [only makes a difference on Windows]



kioslave/recentdocuments/recentdocuments.cpp
<http://git.reviewboard.kde.org/r/103849/#comment9035>

    Same here.


- David Faure


On Feb. 15, 2012, 3:11 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103849/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2012, 3:11 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Add recentdocuments:/ kio slave to kde-runtime.
> Did some little rename "recentdocument -> recentdocuments", based on http://kde-apps.org/content/show.php?content=145878
> 
> 
> Diffs
> -----
> 
>   kioslave/CMakeLists.txt f3d5b00 
>   kioslave/recentdocuments/CMakeLists.txt PRE-CREATION 
>   kioslave/recentdocuments/Messages.sh PRE-CREATION 
>   kioslave/recentdocuments/recentdocuments.h PRE-CREATION 
>   kioslave/recentdocuments/recentdocuments.cpp PRE-CREATION 
>   kioslave/recentdocuments/recentdocuments.protocol PRE-CREATION 
>   kioslave/recentdocuments/recentdocumentsnotifier.h PRE-CREATION 
>   kioslave/recentdocuments/recentdocumentsnotifier.cpp PRE-CREATION 
>   kioslave/recentdocuments/recentdocumentsnotifier.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103849/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120311/90601c86/attachment.htm>