Review Request: kdepasswd KCM: add option to remove the user image

Christoph Feck christoph at maxiom.de
Wed Mar 7 21:59:14 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104054/#review11206
-----------------------------------------------------------

Ship it!



kdepasswd/kcm/chfacedlg.cpp
<http://git.reviewboard.kde.org/r/104054/#comment9014>

    These two lines should have the same identation.


New string => master

Thanks :)

- Christoph Feck


On March 7, 2012, 9:44 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104054/
> -----------------------------------------------------------
> 
> (Updated March 7, 2012, 9:44 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> Currently it is possible to set a user image using the kdepasswd KCM, but it is not possible to remove that image again. This patch adds an appropriate option to the dialogue that pops up when clicking the current image.
> 
> It also adds "i18n" which obviously was forgotten for another button.
> 
> 
> Diffs
> -----
> 
>   kdepasswd/kcm/chfacedlg.h c389e49 
>   kdepasswd/kcm/chfacedlg.cpp a80c5af 
>   kdepasswd/kcm/main.cpp b664f98 
> 
> Diff: http://git.reviewboard.kde.org/r/104054/diff/
> 
> 
> Testing
> -------
> 
> Compiled, and verified that images are properly set up and removed again.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120307/ff479924/attachment.htm>


More information about the kde-core-devel mailing list