Review Request: kdepasswd KCM: add option to remove the user image

Ben Cooksley bcooksley at kde.org
Wed Mar 7 21:15:07 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104054/#review11205
-----------------------------------------------------------


Please cleanup the whitespace issues (shown as red in the Reviewboard diff).
Otherwise this looks fine to me.

- Ben Cooksley


On Feb. 24, 2012, 1:25 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104054/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2012, 1:25 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> Currently it is possible to set a user image using the kdepasswd KCM, but it is not possible to remove that image again. This patch adds an appropriate option to the dialogue that pops up when clicking the current image.
> 
> It also adds "i18n" which obviously was forgotten for another button.
> 
> 
> Diffs
> -----
> 
>   kdepasswd/kcm/chfacedlg.h c389e49 
>   kdepasswd/kcm/chfacedlg.cpp a80c5af 
>   kdepasswd/kcm/main.cpp b664f98 
> 
> Diff: http://git.reviewboard.kde.org/r/104054/diff/
> 
> 
> Testing
> -------
> 
> Compiled, and verified that images are properly set up and removed again.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120307/f8fef552/attachment.htm>


More information about the kde-core-devel mailing list