Review Request: Add cmake config for kdeclarative library.

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/#review11151
-----------------------------------------------------------



experimental/libkdeclarative/KDeclarativeConfig.cmake.in
<http://git.reviewboard.kde.org/r/104140/#comment8985>

    You may want to use something like
    KDeclarative_SOURCE_DIR, which is defined if there is a project call like
    project(KDeclarative)
    in the KDeclarative CMakeLists.txt. You could then also check whether this variable is actually set, and error out if not.



experimental/libkdeclarative/KDeclarativeConfig.cmake.in
<http://git.reviewboard.kde.org/r/104140/#comment8986>

    I didn't check, but how is INCLUDE_INSTALL_DIR set ?
    Is it done by via find_package(KDE4) ?
    In this case, INCLUDE_INSTALL_DIR is a relative path under Windows, so the config file wouldn't work properly under Windows.


- Alexander Neundorf


On March 2, 2012, 6:01 p.m., Lamarque Vieira Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104140/
> -----------------------------------------------------------
> 
> (Updated March 2, 2012, 6:01 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Currently kdeclarative library does not install the KDeclarativeConfig.cmake and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative and so other KDE programs cannot find the library using cmake's find_package macro.
> 
> kde-workspace, kde-runtime and plasma-mobile currently hardcode the "kdeclarative" library name in their CMakeLists.txt, which is not ideal. Once this patch is submitted we need to fix their CMakeLists.txt to use "find_package(KDeclarative REQUIRED)".
> 
> 
> Diffs
> -----
> 
>   experimental/libkdeclarative/CMakeLists.txt 0db647c 
>   experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION 
>   experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104140/diff/
> 
> 
> Testing
> -------
> 
> I can now compile kde-workspace/ksmserver without using the custom made FindKDeclarative.cmake.
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120305/ee865495/attachment.htm>