Review Request: Fix KWidgetItemDelegate not updating on FocusIn and FocusOut

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Sun Mar 4 02:58:58 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104149/
-----------------------------------------------------------

Review request for kdelibs.


Summary (updated)
-----------------

Fix KWidgetItemDelegate not updating on FocusIn and FocusOut


Description (updated)
-------

KWidgetItemDelegate does not update when the itemView gets or loses the focus.
This may cause problems with the text colors of the selected indexes.

I'm not sure if this is the best way to do it, since in all the other places this is done asyncronously using "QTimer::singleShot(0, this, SLOT(initializeModel()))", but this initializes the whole model, and I think it is not needed here. The alternatives are to update the whole model, or to add another slot to initialize only selected items.


Diffs (updated)
-----

  kdeui/itemviews/kwidgetitemdelegate.cpp 828e498 

Diff: http://git.reviewboard.kde.org/r/104149/diff/


Testing
-------


Thanks,

Daniele Elmo Domenichelli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120304/008f41e1/attachment.htm>


More information about the kde-core-devel mailing list