Review Request: Add cmake config for kdeclarative library.
Lamarque Vieira Souza
lamarque at kde.org
Fri Mar 2 18:01:59 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104140/
-----------------------------------------------------------
(Updated March 2, 2012, 6:01 p.m.)
Review request for kdelibs.
Changes
-------
Small changes.
Description (updated)
-------
Currently kdeclarative library does not install the KDeclarativeConfig.cmake and KDeclarativeConfigVersion.cmake to ${LIB_INSTALL_DIR}/cmake/KDeclarative and so other KDE programs cannot find the library using cmake's find_package macro.
kde-workspace, kde-runtime and plasma-mobile currently hardcode the "kdeclarative" library name in their CMakeLists.txt, which is not ideal. Once this patch is submitted we need to fix their CMakeLists.txt to use "find_package(KDeclarative REQUIRED)".
Diffs
-----
experimental/libkdeclarative/CMakeLists.txt 0db647c
experimental/libkdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION
experimental/libkdeclarative/KDeclarativeConfigVersion.cmake.in PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/104140/diff/
Testing (updated)
-------
I can now compile kde-workspace/ksmserver without using the custom made FindKDeclarative.cmake.
Thanks,
Lamarque Vieira Souza
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120302/7fdaa1f1/attachment.htm>
More information about the kde-core-devel
mailing list