Review Request: Remove image/x-wmf and image/x-xfig from image thumbnailer's supported mimetypes

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105371/#review15240
-----------------------------------------------------------


This review has been submitted with commit 2e094436a6cf05d21223c19ccccd234ef1b2db2c by Friedrich W. H. Kossebau to branch master.

- Commit Hook


On June 28, 2012, 5:39 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105371/
> -----------------------------------------------------------
> 
> (Updated June 28, 2012, 5:39 a.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> The declared-as-supported mimetypes of the image thumbnailer are quite broad, assuming a lot of QImageIOPlugin existing and installed. But at least for x-fig and wmf there are no such plugins known, by what I can tell. So the claim of support is wrong.
> 
> Worse: There is no safe way to install an own, better thumbnailer, that one would be only chosen by pure luck. Reason is that the thumbnail creation invoking code just greps the first in the list of found thumbnail plugins, see the code in kde-runtime/kioslave/thumbnail/thumbnail.cpp:
> 
> QString ThumbnailProtocol::pluginForMimeType(const QString& mimeType) {
>     KService::List offers = KMimeTypeTrader::self()->query( mimeType, QLatin1String("ThumbCreator"));
>     if (!offers.isEmpty()) {
>         KService::Ptr serv;
>         serv = offers.first();
>         return serv->library();
>     }
> [...]
> 
> E.g. trying to install an own xfig thumbnailer failed for me.
> 
> While changing the above code to use KMimeTypeTrader::preferredService(...) surely might be also good to do, I have no idea about the impact.
> For now I just would like to have those two wrong claims removed.
> 
> Okay to backport to 4.9 (and 4.8)?
> 
> 
> Diffs
> -----
> 
>   kioslave/thumbnail/imagethumbnail.desktop 53c9a33 
> 
> Diff: http://git.reviewboard.kde.org/r/105371/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120628/05da69d9/attachment.htm>