Review Request: Konqueror: add option to hide/show status bar

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105337/#review15189
-----------------------------------------------------------

Ship it!


Looks good.

One might argue that statusbar visibility should also be part of view profiles (KonqViewManager::loadItem already has support for a "ShowStatusBar" config key, but in KonqFrame::saveConfig the code was commented out for lack of a GUI to control it).
However the use case you describe is really "the user showing the statusbar again after a website hid it", not "the user wants to get rid of all statusbars", so I'd say let's not save this into the profile.

- David Faure


On June 23, 2012, 8:51 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105337/
> -----------------------------------------------------------
> 
> (Updated June 23, 2012, 8:51 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> The referenced bug suggested this option to cover the case where web sites opened new windows (via JS) without user interface elements, if this is the case there is no way to bring back the status bar which can show important information.  A patch was posted (http://lists.kde.org/?l=kfm-devel&m=122885401907547&w=2) a long time ago, but it was rejected because Konqueror's handling of the status bar is special (each view has its own status bar) and the patch took no account of that.
> 
> Hopefully this updated patch does.  The menu option only toggles the status bar of the current view - I did think about making it do the status bars of all of the views simultaneously but was not sure whether this would be the right thing to do.  Of course, for a single view in the window, the option does what is expected anyway.
> 
> There are GUI changes but no I18N strings (the KStandardAction is used).
> 
> 
> This addresses bug 111162.
>     http://bugs.kde.org/show_bug.cgi?id=111162
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqmainwindow.h 1666370 
>   konqueror/src/konqmainwindow.cpp 0b49be5 
>   konqueror/src/konqueror.rc f788484 
> 
> Diff: http://git.reviewboard.kde.org/r/105337/diff/
> 
> 
> Testing
> -------
> 
> Built Konqueror with these changes, tested with file management and web browsing profiles with various window splits.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120627/fd8488cc/attachment.htm>