Review Request: kjs: Implement JSON.parse

[Bernd Buschinski]

> On June 10, 2012, 6:57 p.m., Maks Orlovich wrote:
> > kjs/json_object.cpp, line 37
> > <http://git.reviewboard.kde.org/r/105056/diff/3/?file=65731#file65731line37>
> >
> >     What namespace do the symbols for this end up in?
> >

like all other generated luts, in the KJS namespace


> On June 10, 2012, 6:57 p.m., Maks Orlovich wrote:
> > kjs/json_object.cpp, line 107
> > <http://git.reviewboard.kde.org/r/105056/diff/3/?file=65731#file65731line107>
> >
> >     I think it's true, but needs one more proviso: the check on line 89.

Fixed with extra exception check


> On June 10, 2012, 6:57 p.m., Maks Orlovich wrote:
> > kjs/jsonlexer.cpp, line 193
> > <http://git.reviewboard.kde.org/r/105056/diff/3/?file=65733#file65733line193>
> >
> >     I don't think this is needed anymore?
> >     (Nor the similar one in arrays)

This is still needed, as object is NULL on if we get called from called from JSONArray-TokLBrace.
Like the comment says.


> On June 10, 2012, 6:57 p.m., Maks Orlovich wrote:
> > kjs/jsonlexer.cpp, line 292
> > <http://git.reviewboard.kde.org/r/105056/diff/3/?file=65733#file65733line292>
> >
> >     This looks like it will run out of stack space pretty quickly. I think it would be better to instead of firstArrayRun to have something more like what you have for objects. (Or just use propAdded in the same way)
> >

I can't use propAdded because it has a different default-start value.


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review14590
-----------------------------------------------------------


On May 28, 2012, 7:52 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> -----------------------------------------------------------
> 
> (Updated May 28, 2012, 7:52 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -----
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120618/83bfb7b9/attachment.htm>