Review Request: [dolphin] Fix the warning generated by desktop-file-validate for dolphin.desktop

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105288/#review14833
-----------------------------------------------------------

Ship it!


Thanks, looks fine! (btw: from my point of view no review-request would have been necessary for this fix, but of course it is exemplary doing it this way :-))

- Peter Penz


On June 18, 2012, 1:47 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105288/
> -----------------------------------------------------------
> 
> (Updated June 18, 2012, 1:47 a.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Description
> -------
> 
> "desktop-file-validate dolphin.dekstop" generates this:
> 
> dolphin.desktop: error: (will be fatal in the future): value "FileManager" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: System;FileTools
> 
> FDO menu specification[1] suggests "System;FileTools" should be used together with the "FileManager" category.
> 
> The patch simply adds the missing "FileTools"
> 
> [1] http://standards.freedesktop.org/menu-spec/latest/apa.html
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphin.desktop cd9da17 
> 
> Diff: http://git.reviewboard.kde.org/r/105288/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120618/de46da60/attachment.htm>