Review Request: fix for some typos
Jaime Torres Amate
jtamate at gmail.com
Sat Jun 16 16:37:40 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105278/
-----------------------------------------------------------
Review request for kdelibs.
Description
-------
1. Do not want to check m_startDate.isValid() twice and m_endDate.isValid() none.
2. why do not want to delete d->authAction if it is nulled after that.
3. Is really the code after the break unwanted code?
4. if ok is not initialized, sometimes while(ok) could do nothing.
Diffs
-----
kdecore/date/kcalendarera.cpp 0a21e37
kdeui/actions/kaction.cpp 309cf82
kio/kfile/kpropertiesdialog.cpp feb0c9e
sonnet/unicode/parseucd/parseucd.cpp 1c9b90e
Diff: http://git.reviewboard.kde.org/r/105278/diff/
Testing
-------
6 months or more with it locally.
Thanks,
Jaime Torres Amate
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120616/5b345e83/attachment.htm>
More information about the kde-core-devel
mailing list