Review Request: fix for some typos

Jaime Torres Amate jtamate at
Sat Jun 16 16:37:40 BST 2012

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


1. Do not want to check m_startDate.isValid() twice and m_endDate.isValid() none.
2. why do not want to delete d->authAction if it is nulled after that.
3. Is really the code after the break unwanted code?
4. if ok is not initialized, sometimes while(ok) could do nothing.


  kdecore/date/kcalendarera.cpp 0a21e37 
  kdeui/actions/kaction.cpp 309cf82 
  kio/kfile/kpropertiesdialog.cpp feb0c9e 
  sonnet/unicode/parseucd/parseucd.cpp 1c9b90e 



6 months or more with it locally.


Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list