Review Request: UDisks mount vfat filesystems with flush option.

[Gary Greene]

On Jun 13, 2012, at 2:32 PM, Konstantinos Smanis wrote:

> On Tue, Jun 12, 2012 at 11:33 AM, Maarten De Meyer
> <de.meyer.maarten at gmail.com> wrote:
>> 
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/105224/
>> 
>> Review request for kdelibs, Solid and Lukáš Tinkl.
>> By Maarten De Meyer.
>> 
>> Description
>> 
>> This patch mounts vfat filesystems (mostly usb devices) with the flush
>> option when using the UDisks backend. The hal backend already did this.
>> The flush option makes sure changes are written to the device immediately.
>> 
>> Please let me know it this should be implemented in an other (optional)
>> way or if this should be in the UDev rules directly.
>> 
>> ps. I do not have commit rights.
>> 
>> Testing
>> 
>> Compiled without error, mounted multiple devices without problems.
>> 
>> Bugs: 273792
>> 
>> Diffs
>> 
>> solid/solid/backends/udisks/udisksstorageaccess.cpp (7d72a88)
>> 
>> View Diff
> 
> I tested the patch against 4.8.3, works as expected.
> 
> However, I too think that this option should be implemented somewhere
> else in the stack (udisks/udev: whatever is most fit). Although a sane
> default, you should be able to configure it more easily.

I'm erring on the side that this smells of policy, which should NOT be hard coded, but rather site or host specified. If I'm a user, I might rather have my application's writer thread not block on write, but cache then write via the kernel, then so be it (yes, I understand the risk related if I remove the disk before the flush has occurred, but in this case, that's what umount is for, which calls flush before unmounting the filesystem.....

--
Gary L. Greene, Jr.
===============================================================
Developer and Project Lead for the AltimatOS open source project
See http://www.altimatos.com/ for more information
===============================================================

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120615/7342e3c4/attachment.htm>