Review Request: implement support for window.onhashchange

[Maks Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104946/#review14592
-----------------------------------------------------------

Ship it!


Looks good, except for a few nitpicks.


khtml/ecma/kjs_events.cpp
<http://git.reviewboard.kde.org/r/104946/#comment11540>

    5, not 7



khtml/ecma/kjs_window.h
<http://git.reviewboard.kde.org/r/104946/#comment11541>

    Add HashChangeEventCtor as well?


- Maks Orlovich


On May 15, 2012, 12:56 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104946/
> -----------------------------------------------------------
> 
> (Updated May 15, 2012, 12:56 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Implement a custom hashchange event, and make the khtml kpart emit it
> when we are asked to navigate to another anchor, and the ref is
> different.
> 
> 
> Diffs
> -----
> 
>   khtml/ecma/kjs_events.h 3727b94 
>   khtml/ecma/kjs_events.cpp e7c7e5b 
>   khtml/ecma/kjs_html.h 089b550 
>   khtml/ecma/kjs_html.cpp d64e07c 
>   khtml/ecma/kjs_window.h 416b045 
>   khtml/ecma/kjs_window.cpp e75e6e7 
>   khtml/html/html_baseimpl.cpp baa13b5 
>   khtml/khtml_part.cpp 24589e4 
>   khtml/misc/htmlattrs.in 21a2363b 
>   khtml/misc/htmlnames.h e3adbe7 
>   khtml/misc/htmlnames.cpp 3b22b6d 
>   khtml/xml/dom2_eventsimpl.h 5b452d2 
>   khtml/xml/dom2_eventsimpl.cpp f01a533 
> 
> Diff: http://git.reviewboard.kde.org/r/104946/diff/
> 
> 
> Testing
> -------
> 
> tested extensively against http://lolcats.iskrembilen.com/
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120610/408345a0/attachment.htm>