Review Request: kjs: FunctionObject prototype attribute should be [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: false

[Maks Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105122/#review14588
-----------------------------------------------------------

Ship it!


Did you test function expressions (as in x = function foo()) as well?
The constructor is used for stuff like x = new Function(), if I get what you were referring to.


- Maks Orlovich


On May 31, 2012, 9 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105122/
> -----------------------------------------------------------
> 
> (Updated May 31, 2012, 9 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: FunctionObject prototype attribute should be [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: false
> ECMA Edition 5.1r6 - 15.3.5.2
> 
> the prototype must have DontEnum property otherwise it shows up as enumerable key.
> 
> 
> I expected that this must be fixed in the function_object.cpp constructor, but its never used in for code like
> 
> function foo() {};
> 
> 
> Diffs
> -----
> 
>   kjs/nodes.cpp 0b0749a 
> 
> Diff: http://git.reviewboard.kde.org/r/105122/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120610/378be51f/attachment.htm>