kdelibs splitting: May results, plans for June
Alexander Neundorf
neundorf at kde.org
Wed Jun 6 14:59:16 BST 2012
On Wednesday, June 06, 2012 10:07:41 AM Kevin Ottens wrote:
...
> > > We completed the following three new frameworks:
> > > * karchive
> >
> > I wouldn't call karchive "complete".
> > It is not splitted.
> > E.g. it uses include dirs from the surrounding kdelibs:
> >
> > include_directories(
> >
> > ${CMAKE_CURRENT_SOURCE_DIR}/../src
> > ${CMAKE_CURRENT_BINARY_DIR}/../src
> > ${CMAKE_SOURCE_DIR}/kio/httpfilter
> >
> > )
>
> Ah right, the files in kio/httpfilter are not used anymore but I forgot to
> remove the include_directories in autotests. Fixed now.
Cool :-)
> > Also, it uses BZIP2_FOUND and LZMA_FOUND but doesn't search for them,
> > but
> > instead uses the results from the containing kdelibs.
>
> Well, I see the find_package calls in ConfigureChecks.cmake, am I missing
> something?
Ah, right.
Can you put a copy of FindLibLZMA.cmake into tier1/karchive/cmake/ ?
(it will be in cmake 2.8.9)
Then we don't need the CMAKE_MODULE_PATH from kdelibs anymore, and karchive is
more standalone.
Alex
More information about the kde-core-devel
mailing list