Review Request: type of NET::WindowTypeMask

[Jaime Torres Amate]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105142/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

According to clang++, the implicit type conversion for NET::WindowTypeMask is unsigned long, not int.

implicit conversion from 'NET::WindowTypeMask' to 'int' changes value from 18446744073709551615 to -1 [-Wconstant-conversion]
            NET::WindowType type = info.windowType(NET::AllTypesMask);
                                   ~~~~            ^~~~~~~~~~~~~~~~~
probably because in NET:WindowTypeMask, AllTypesMask is declared as:
AllTypesMask     = 0LU-1  ///< All window types.

The other possible solution could be to declare
AllTypesMask     = -1  ///< All window types.
to make NET::WindowType to be an int.


Diffs
-----

  tier1/kwindowsystem/src/kwindowinfo.h b899d22 
  tier1/kwindowsystem/src/kwindowinfo_mac.cpp 9756254 
  tier1/kwindowsystem/src/kwindowinfo_win.cpp d392fe9 
  tier1/kwindowsystem/src/kwindowinfo_x11.cpp f382e9c 

Diff: http://git.reviewboard.kde.org/r/105142/diff/


Testing
-------


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120604/eafda390/attachment.htm>