Review Request: properly pass the NOGUI flag

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105787/#review16629
-----------------------------------------------------------

Ship it!


Mek seems to have added it in d37888c6c332ed431f1e08d3cc8b558cf6c98165 for some OS X use case, but it indeed seems to have been broken from the beginning (I thus don't even know if this is really still needed, and that code path in line 873 doesn't seem to have been updated by d502bccc3bcfdc5b1f05b4ee4a93a91722b2a922).

As for "who uses NOGUI", http://lxr.kde.org/search?filestring=&string=kde4_add_unit_test+NOGUI

- Raphael Kubo da Costa


On July 29, 2012, 11:14 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105787/
> -----------------------------------------------------------
> 
> (Updated July 29, 2012, 11:14 p.m.)
> 
> 
> Review request for Build System and kdelibs.
> 
> 
> Description
> -------
> 
> While running some KDevelop tests, I've seen some output pointing to this. Looks like an error to me, so we'd better fix it :).
> 
> 
> Diffs
> -----
> 
>   cmake/modules/KDE4Macros.cmake 2aa948c 
> 
> Diff: http://git.reviewboard.kde.org/r/105787/diff/
> 
> 
> Testing
> -------
> 
> kdelibs and all keep compiling ok, I'm unsure who uses NOGUI there.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120730/059fc865/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem at kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem