Review Request: Only show the "Find File" action for local URL in Dolphin's KPart

David Faure faure at kde.org
Sat Jul 21 08:32:44 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105607/#review16174
-----------------------------------------------------------



dolphin/src/dolphinpart.cpp
<http://git.reviewboard.kde.org/r/105607/#comment12768>

    Overzealous search/replace: don't touch the contents of the i18nc()...


- David Faure


On July 20, 2012, 11:38 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105607/
> -----------------------------------------------------------
> 
> (Updated July 20, 2012, 11:38 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> The attached patch hides the "Find File" action in Dolphin's KPart since finding files is only supported for local protocols. It does not work for remote protocols. See bug report listed above.
> 
> 
> This addresses bug 279283.
>     http://bugs.kde.org/show_bug.cgi?id=279283
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinpart.h 0a8ce07 
>   dolphin/src/dolphinpart.cpp b3b7cd0 
> 
> Diff: http://git.reviewboard.kde.org/r/105607/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120721/6e93ecb8/attachment.htm>


More information about the kde-core-devel mailing list