Review Request: KWallet Password Prompt Dialog In Your Face

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105628/#review16156
-----------------------------------------------------------


Well, I already mentioned it on IRC, but what you do is not "keep KWallet above KMail", but "keep KWallet above all windows".

Let's say, I start KMail. Since it needs a lot of time to start, I already switch to another window to work somewhere else. When KMail later asks for KWallet, it will interrupt me there.

I understand that it is much harder to fix it correctly (basically KMail would have to register itself as the current "Akonadi UI", so that all agents know where to put the window). I fear that once this patch is in, no further attempt is done. While it's nice that we separate components in KDE, we should make sure they still act integrated.

- Christoph Feck


On July 20, 2012, 1:41 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105628/
> -----------------------------------------------------------
> 
> (Updated July 20, 2012, 1:41 p.m.)
> 
> 
> Review request for KDE Runtime, David Faure and Fredrik Höglund.
> 
> 
> Description
> -------
> 
> This is an attempt to make the KWallet password prompt much harder to ignore or miss.
> 
> Now the prompt should always be in front of the parent window. and it should unminimize if needed, and demand attention.
> 
> 
> Diffs
> -----
> 
>   kwalletd/kwalletd.cpp 309c45f 
> 
> Diff: http://git.reviewboard.kde.org/r/105628/diff/
> 
> 
> Testing
> -------
> 
> Just using it in various scenarios.
> For example, if the akonadi maildispatcher needs to open kwallet now the password prompt is always in front of kmail
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120720/d3946b1d/attachment.htm>