Review Request: Fix Warning messages when closing About popup

Albert Astals Cid tsdgeos at terra.es
Thu Jul 19 22:08:59 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105627/
-----------------------------------------------------------

Review request for kdelibs, Frederik Gladhorn and David Faure.


Description
-------

There is a too agressive check in KWidgetItemDelegateEventListener that complains about
"User of KWidgetItemDelegate should not delete widgets created by createItemWidgets!"
when closing an about dialog.

I tried making it less agressive but since i could not, i'm just deleting things in a different order in the destruction of KAboutApplicationDialog so that the warning is not triggered and our users get angry


This addresses bug 301628.
    http://bugs.kde.org/show_bug.cgi?id=301628


Diffs
-----

  kdeui/dialogs/kaboutapplicationdialog.cpp 2c98f74 

Diff: http://git.reviewboard.kde.org/r/105627/diff/


Testing
-------

Dialog still works, valgrind doesn't complain, the warning is gone


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120719/88584b2e/attachment.htm>


More information about the kde-core-devel mailing list