Review Request: Only show the "Find File" action for local URL in Dolphin's KPart

[Dawit Alemayehu]

> On July 18, 2012, 11:26 a.m., Parker Coates wrote:
> > dolphin/src/dolphinpart.cpp, line 302
> > <http://git.reviewboard.kde.org/r/105607/diff/1/?file=73218#file73218line302>
> >
> >     Would it not be better to disable the action instead of hiding it?
> >     
> >     Disabling the action lets the user know that the action cannot be performed at this time. Hiding the action just causes them to look for it elsewhere and eventually give up in frustration.

I do not have any particular objection to disabling the action instead.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105607/#review16066
-----------------------------------------------------------


On July 18, 2012, 2:53 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105607/
> -----------------------------------------------------------
> 
> (Updated July 18, 2012, 2:53 a.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> The attached patch hides the "Find File" action in Dolphin's KPart since finding files is only supported for local protocols. It does not work for remote protocols. See bug report listed above.
> 
> 
> This addresses bug 279283.
>     http://bugs.kde.org/show_bug.cgi?id=279283
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinpart.cpp b3b7cd0 
> 
> Diff: http://git.reviewboard.kde.org/r/105607/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120719/4a81c54b/attachment.htm>