Review Request: Add submenu support to QML shutdown dialog.

[Lamarque Vieira Souza]

> On July 17, 2012, 6:19 p.m., Konstantinos Smanis wrote:
> > I forgot to mention that the submenus should only be created if Grub2 or Burg is the selected Boot Manager in KDM. Other bootloaders (grub, lilo) should still be able to use '>' in the menu titles without creating submenus. See the ksmserver part of the other patch I am submitting for branch KDE/4.8 (https://git.reviewboard.kde.org/r/105563/).
> 
> Lamarque Vieira Souza wrote:
>     I will fix that tonight. I need to go now.
> 
> Oswald Buddenhagen wrote:
>     i would recommend against doing anything until the kdm patch is final

Too late, this patch and the commit to fix the issue above are already pushed. ksmserver now works with or without the kdm patch. It will create a flat menu if the kdm patch is not applied or user is using a boot manager different from Grub2 or Burg.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105568/#review16022
-----------------------------------------------------------


On July 14, 2012, 6:53 p.m., Lamarque Vieira Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105568/
> -----------------------------------------------------------
> 
> (Updated July 14, 2012, 6:53 p.m.)
> 
> 
> Review request for KDE Runtime and Konstantinos Smanis.
> 
> 
> Description
> -------
> 
> Add support to show submenus in the new QML shutdown dialog. I think this patch can be improved, the GUI too. When I have more time I will go back to improve it, until there you can send suggestions.
> 
> The patch assumes rebootOptions now contains strings like:
> 
> entry1
> submenu1 > subentry 1.1
> submenu1 > subentry 1.2
> submenu2 > subentry 2.1
> submenu2 > subsubmenu 1 > subsubentry 2.1.1
> entry2
> 
> The character '>' is the separator for submenus.
> 
> 
> This addresses bug 297209.
>     http://bugs.kde.org/show_bug.cgi?id=297209
> 
> 
> Diffs
> -----
> 
>   ksmserver/themes/default/ContextMenu.qml 6f2f1fd 
>   ksmserver/themes/default/MenuItem.qml 74bb03f 
>   ksmserver/themes/default/main.qml 7e78761 
> 
> Diff: http://git.reviewboard.kde.org/r/105568/diff/
> 
> 
> Testing
> -------
> 
> Submenus are created and it emits rebootRequested2 signal with the correct index.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/105568/s/635/
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120717/3701f62a/attachment.htm>