Review Request: khtml/kmultipart/kmultipart.cpp uses wrong signal

David Faure faure at kde.org
Fri Jul 13 14:57:08 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105552/#review15802
-----------------------------------------------------------

Ship it!


Woah that was long ago.

- David Faure


On July 13, 2012, 12:02 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105552/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 12:02 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> khtml/kmultipart/kmultipart.cpp uses wrong signal (obviously a porting error)
> 
> Error:
> 
> Object::connect: No such signal KHTMLPartBrowserExtension::openURLNotify()
> Object::connect:  (sender name:   'KHTMLBrowserExtension')
> Object::connect: No such signal KHTMLPartBrowserExtension::setLocationBarURL(QString)
> Object::connect:  (sender name:   'KHTMLBrowserExtension')
> 
> 
> Diffs
> -----
> 
>   khtml/kmultipart/kmultipart.cpp fe531e5 
> 
> Diff: http://git.reviewboard.kde.org/r/105552/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120713/4709e600/attachment.htm>


More information about the kde-core-devel mailing list