Review Request: konqueror shall allow to click a mailto: link without showing a (...this URL is untrusted...) confirmation dialog

Thu Jul 12 17:15:53 BST 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105395/#review15734
-----------------------------------------------------------

Ship it!

Looks good. I'm curious as to why this wasn't necessary before, but anyway: please commit this for 4.9, obviously.

- David Faure

On June 30, 2012, 1:21 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105395/
> -----------------------------------------------------------
> 
> (Updated June 30, 2012, 1:21 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> When a non-local webpage contains a mailto: link and you click on it, konqueror shows a confirmation dialog:
> 
> This untrusted page links to
> mailto: some.name at some.domain.
> Do you want to follow the link?
> 
> (using the page with opera or firefox does not give any such warning and opens kmail)
> 
> The check is done by KAuthorized:authorizeUrlAction("redirect", pageURL, linkURL);
> 
> This patch fixes this by always allowing a redirection to a mailto link.
> 
> 
> Diffs
> -----
> 
>   kdecore/kernel/kauthorized.cpp f7d795a 
> 
> Diff: http://git.reviewboard.kde.org/r/105395/diff/
> 
> 
> Testing
> -------
> 
> The following simple html page when
> the page is served from a local running HTTP Server
> ( http://localhost:8080/data/test.html )
> 
> <html>
> <body>
> <a href="mailto:test.test at test.at">test.test at test.at</a>
> </body>
> </html>
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120712/5f0562e8/attachment.htm>