Review Request: Do not use user selected default browser to open XML files

David Faure faure at kde.org
Sun Jul 8 08:56:06 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105476/#review15536
-----------------------------------------------------------



kio/kio/krun.cpp
<http://git.reviewboard.kde.org/r/105476/#comment12145>

    OK, but add application/xhtml+xml instead, you most probably want that one.
    
    It wasn't there because it's a subclass of application/xml so it was covered already.


- David Faure


On July 7, 2012, 7:16 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105476/
> -----------------------------------------------------------
> 
> (Updated July 7, 2012, 7:16 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> The attach patch prevents KRun from opening XML files in the user configured default browser. That way clicking on an XML document in Dolphin does not result in the file being open with the default browser. 
> 
> Technically I am arguing against the position I took in the review that resulted in this change ; so this is my own doing in the first place. See https://git.reviewboard.kde.org/r/103524/ for the details.
> 
> 
> This addresses bug 291177.
>     http://bugs.kde.org/show_bug.cgi?id=291177
> 
> 
> Diffs
> -----
> 
>   kio/kio/krun.cpp 53ab878 
> 
> Diff: http://git.reviewboard.kde.org/r/105476/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120708/fb1c0bda/attachment.htm>


More information about the kde-core-devel mailing list