Review Request: kjs: Implement Date.toISOString

Maks Orlovich maksim at kde.org
Fri Jul 6 14:39:28 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105386/#review15459
-----------------------------------------------------------



kjs/date_object.cpp
<http://git.reviewboard.kde.org/r/105386/#comment12089>

    what if hour becomes negative here?
    


- Maks Orlovich


On June 29, 2012, 6:06 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105386/
> -----------------------------------------------------------
> 
> (Updated June 29, 2012, 6:06 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Implement Date.toISOString
> 
> mostly copied from ToUTCString but with different format and behavior,
> YYYY-MM-DDTHH:mm:ss:sssZ and exception throwing on invalid date
> 
> 
> Diffs
> -----
> 
>   kjs/date_object.h ed45720 
>   kjs/date_object.cpp 8a1fc2c 
> 
> Diff: http://git.reviewboard.kde.org/r/105386/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120706/5306f35c/attachment.htm>


More information about the kde-core-devel mailing list