Review Request: Fix a memory leak in KDateTable

Christoph Feck christoph at maxiom.de
Thu Jul 5 20:53:21 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105451/#review15439
-----------------------------------------------------------

Ship it!



kdeui/widgets/kdatetable.cpp
<http://git.reviewboard.kde.org/r/105451/#comment12061>

    Actually, I wonder how that would have worked before. If the date was not in hash, it would have inserted and returned a null pointer.
    
    Probably a Qt 3 porting relict, looks better now.


- Christoph Feck


On July 5, 2012, 6:07 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105451/
> -----------------------------------------------------------
> 
> (Updated July 5, 2012, 6:07 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> KDateTablePrivate::DatePaintingMode is dynamically allocated but never freed.
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/kdatetable.cpp f551742 
> 
> Diff: http://git.reviewboard.kde.org/r/105451/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120705/0b2debcc/attachment.htm>


More information about the kde-core-devel mailing list