Review Request: kjs: Implement JSON.stringify

[Bernd Buschinski]

> On July 4, 2012, 2:30 p.m., Maks Orlovich wrote:
> > kjs/jsonstringify.cpp, line 69
> > <http://git.reviewboard.kde.org/r/105057/diff/2/?file=65648#file65648line69>
> >
> >     Does this do the right thing if it's shorter than 10?

yes, it does


> On July 4, 2012, 2:30 p.m., Maks Orlovich wrote:
> > kjs/jsonstringify.h, line 65
> > <http://git.reviewboard.kde.org/r/105057/diff/2/?file=65647#file65647line65>
> >
> >     Don't use std::set, it's sloowwww. Better use WTF::HashSet if at all possible.

WTF::HashSet<UString> just drives me mad, it won't compile easily that way.
I only found UString::Rep* HashSet useage in kjs, but just storing the rep in this case does not work...


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105057/#review14245
-----------------------------------------------------------


On June 1, 2012, 1:30 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105057/
> -----------------------------------------------------------
> 
> (Updated June 1, 2012, 1:30 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Implement JSON.stringify
> 
> patch needs https://git.reviewboard.kde.org/r/105056/ (JSON.parse)
> 
> 
> Diffs
> -----
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/CommonIdentifiers.h 8ee40e8 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonstringify.h PRE-CREATION 
>   kjs/jsonstringify.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105057/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120704/161dcaf3/attachment.htm>