Review Request: kjs: Implement JSON.stringify

[Maks Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105057/#review14245
-----------------------------------------------------------



kjs/jsonstringify.h
<http://git.reviewboard.kde.org/r/105057/#comment11267>

    Don't use std::set, it's sloowwww. Better use WTF::HashSet if at all possible.



kjs/jsonstringify.cpp
<http://git.reviewboard.kde.org/r/105057/#comment11268>

    Remember, toString can throw exceptions :(
    



kjs/jsonstringify.cpp
<http://git.reviewboard.kde.org/r/105057/#comment11269>

    Does this do the right thing if it's shorter than 10?


- Maks Orlovich


On June 1, 2012, 1:30 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105057/
> -----------------------------------------------------------
> 
> (Updated June 1, 2012, 1:30 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Implement JSON.stringify
> 
> patch needs https://git.reviewboard.kde.org/r/105056/ (JSON.parse)
> 
> 
> Diffs
> -----
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/CommonIdentifiers.h 8ee40e8 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonstringify.h PRE-CREATION 
>   kjs/jsonstringify.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105057/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120704/3d373a8e/attachment.htm>