Review Request: kjs: Implement JSON.parse

[Maks Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review15374
-----------------------------------------------------------



kjs/json_object.cpp
<http://git.reviewboard.kde.org/r/105056/#comment11972>

    I think this may not be quite true in case the user function adds non-numeric properties to an array.



kjs/jsonlexer.h
<http://git.reviewboard.kde.org/r/105056/#comment11973>

    Unused?
    



kjs/jsonlexer.cpp
<http://git.reviewboard.kde.org/r/105056/#comment11974>

    I don't think this is needed anymore.



kjs/jsonlexer.cpp
<http://git.reviewboard.kde.org/r/105056/#comment11975>

    Again, please fix this to not be needlessly recursive.
    


- Maks Orlovich


On June 18, 2012, 10:25 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> -----------------------------------------------------------
> 
> (Updated June 18, 2012, 10:25 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Implement JSON.parse
> 
> 
> Diffs
> -----
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/interpreter.cpp cf1acf1 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonlexer.h PRE-CREATION 
>   kjs/jsonlexer.cpp PRE-CREATION 
>   kjs/libkjs.map e9f679f 
> 
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120704/b5b0cc9c/attachment.htm>