Review Request: kjs: Use toPrimitive in Array.join to get the correct String

Maks Orlovich maksim at kde.org
Wed Jul 4 14:39:23 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105391/#review15371
-----------------------------------------------------------



kjs/array_object.cpp
<http://git.reviewboard.kde.org/r/105391/#comment11970>

    I think you can just use toString regardless of whether it's an object or not.
    (But don't forget to check hadException, of course)
    
    


- Maks Orlovich


On June 30, 2012, 2:10 a.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105391/
> -----------------------------------------------------------
> 
> (Updated June 30, 2012, 2:10 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Use toPrimitive in Array.join to get the correct String
> 
> the default value case for String is present here, as testcase S15.4.4.5_A3.2_T2 shows
> 
> 
> Diffs
> -----
> 
>   kjs/array_object.cpp 0da29b0 
> 
> Diff: http://git.reviewboard.kde.org/r/105391/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120704/a950af5d/attachment.htm>


More information about the kde-core-devel mailing list