Review Request: Move KdepimLibs dependency to DrKonqi

[Aurélien Gâteau]

> On July 3, 2012, 12:07 p.m., Aurélien Gâteau wrote:
> > Was this actually asked by packagers? I am no expert, but the feedback I had from a Debian packager working on CMake projects was that he preferred to have all dependencies listed in the top-level CMakeLists.txt.
> > 
> > The reason he gave were:
> > - It is easier to list all dependencies this way
> > - It avoids the situation where A/CMakeLists.txt has an optional dependency on package Foo and B/CMakeLists.txt has a mandatory dependency on Foo (possibly added later).

Mmm... I didn't notice you were working on Gentoo. You most likely know more than I do, but still I would be interested to know how this change helps you.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105402/#review15336
-----------------------------------------------------------


On July 1, 2012, 4:23 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105402/
> -----------------------------------------------------------
> 
> (Updated July 1, 2012, 4:23 p.m.)
> 
> 
> Review request for KDE Runtime and George Kiagiadakis.
> 
> 
> Description
> -------
> 
> This patch moves the dependency on KdepimLibs to /drkonqi, since that's the program requiring it.
> 
> This is done to assist downstream packaging.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5091890a0768fd553f972a9b113f7f826d63f356 
>   drkonqi/CMakeLists.txt 102185ac52f558fba78cf2da80a1e8a0fe870e18 
> 
> Diff: http://git.reviewboard.kde.org/r/105402/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120703/69c01bbf/attachment.htm>