Review Request: Do not leave dangling pointers in KToolbar when xml clients die

Albert Astals Cid tsdgeos at terra.es
Sun Jul 1 10:11:15 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105399/
-----------------------------------------------------------

Review request for kdelibs and David Faure.


Description
-------

If we add xmlclients to ktoolbar when plugging them in we should remove them when unplugging them


This addresses bug 296622.
    http://bugs.kde.org/show_bug.cgi?id=296622


Diffs
-----

  kdeui/widgets/ktoolbar.h c78263f 
  kdeui/widgets/ktoolbar.cpp c6bd200 
  kdeui/xmlgui/kxmlguifactory_p.cpp 083ddf5 

Diff: http://git.reviewboard.kde.org/r/105399/diff/


Testing
-------

The crash is gone as described in the steps in the bug to reproduce


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120701/87129d24/attachment.htm>


More information about the kde-core-devel mailing list