Review Request: Port shutdown dialog to QML

[Lamarque Vieira Souza]

> On Jan. 30, 2012, 4:44 p.m., Raphael Kubo da Costa wrote:
> > ksmserver/FindKDeclarative.cmake, line 14
> > <http://git.reviewboard.kde.org/r/103621/diff/8/?file=48390#file48390line14>
> >
> >     Where is Copyright.txt? :)
> >     
> >     If you move this file to cmake/modules you can share the license header with the other files there and just point to COPYING-CMAKE-SCRIPTS (if you do so, it's probably better not to install it, btw).

Copyright.txt added. By the way, kdelibs does not include that file for FindJPEG.cmake. If I move it to cmake/modules it is installed by default and Alexander Neundorf <neundorf at kde.org> already said to do not install it.


> On Jan. 30, 2012, 4:44 p.m., Raphael Kubo da Costa wrote:
> > ksmserver/FindKDeclarative.cmake, line 25
> > <http://git.reviewboard.kde.org/r/103621/diff/8/?file=48390#file48390line25>
> >
> >     Can you elaborate on why KDECLARATIVE_LIBRARY is being used/set?

I cannot. I used FindJPEG.cmake as an example as suggested by Alexander Neundorf. I do not know why it is used in FindJPEG.cmake and how it works.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103621/#review10238
-----------------------------------------------------------


On Jan. 30, 2012, 5:08 p.m., Lamarque Vieira Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103621/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2012, 5:08 p.m.)
> 
> 
> Review request for KDE Base Apps and KDE Runtime.
> 
> 
> Description
> -------
> 
> Port shutdown dialog to QML. Two QML themes are included: default, which mimics the current shutdown dialog look & feel, and contour, which is used in Plasma Active.
> 
> 
> This addresses bugs 216853 and 216853.
>     http://bugs.kde.org/show_bug.cgi?id=216853
>     http://bugs.kde.org/show_bug.cgi?id=216853
> 
> 
> Diffs
> -----
> 
>   ksmserver/CMakeLists.txt 295b96e 
>   ksmserver/Copyright.txt PRE-CREATION 
>   ksmserver/FindKDeclarative.cmake PRE-CREATION 
>   ksmserver/Messages.sh 0aa8bab 
>   ksmserver/shutdown.cpp 7fd1e11 
>   ksmserver/shutdowndlg.h e5f0942 
>   ksmserver/shutdowndlg.cpp a09a1a7 
>   ksmserver/themes/contour/ContourButton.qml PRE-CREATION 
>   ksmserver/themes/contour/main.qml PRE-CREATION 
>   ksmserver/themes/contour/metadata.desktop PRE-CREATION 
>   ksmserver/themes/contour/screenshot.png PRE-CREATION 
>   ksmserver/themes/default/ContextMenu.qml PRE-CREATION 
>   ksmserver/themes/default/KSMButton.qml PRE-CREATION 
>   ksmserver/themes/default/MenuItem.qml PRE-CREATION 
>   ksmserver/themes/default/helper.js PRE-CREATION 
>   ksmserver/themes/default/main.qml PRE-CREATION 
>   ksmserver/themes/default/metadata.desktop PRE-CREATION 
>   ksmserver/themes/default/screenshot.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103621/diff/diff
> 
> 
> Testing
> -------
> 
> Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work in 4.7.x because the default theme requires kde-runtime 4.8's declarative imports.
> 
> TODO:
> 
> . test right to left language support.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/103621/s/400/
> New version with label accelerator working
>   http://git.reviewboard.kde.org/r/103621/s/407/
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120130/c4ca5e79/attachment.htm>