Review Request: Port shutdown dialog to QML
Lamarque Vieira Souza
lamarque at kde.org
Mon Jan 30 16:35:41 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103621/
-----------------------------------------------------------
(Updated Jan. 30, 2012, 4:35 p.m.)
Review request for KDE Base Apps and KDE Runtime.
Changes
-------
Change some issues with FindKDeclarative.cmake.
Description
-------
Port shutdown dialog to QML. Two QML themes are included: default, which mimics the current shutdown dialog look & feel, and contour, which is used in Plasma Active.
This addresses bugs 216853 and 216853.
http://bugs.kde.org/show_bug.cgi?id=216853
http://bugs.kde.org/show_bug.cgi?id=216853
Diffs (updated)
-----
ksmserver/themes/default/main.qml PRE-CREATION
ksmserver/themes/contour/main.qml PRE-CREATION
ksmserver/themes/contour/metadata.desktop PRE-CREATION
ksmserver/themes/contour/screenshot.png PRE-CREATION
ksmserver/themes/default/ContextMenu.qml PRE-CREATION
ksmserver/themes/default/KSMButton.qml PRE-CREATION
ksmserver/themes/default/MenuItem.qml PRE-CREATION
ksmserver/themes/default/helper.js PRE-CREATION
ksmserver/themes/contour/ContourButton.qml PRE-CREATION
ksmserver/shutdowndlg.cpp a09a1a7
ksmserver/CMakeLists.txt 295b96e
ksmserver/FindKDeclarative.cmake PRE-CREATION
ksmserver/Messages.sh 0aa8bab
ksmserver/shutdown.cpp 7fd1e11
ksmserver/shutdowndlg.h e5f0942
ksmserver/themes/default/metadata.desktop PRE-CREATION
ksmserver/themes/default/screenshot.png PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103621/diff/diff
Testing (updated)
-------
Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work in 4.7.x because the default theme requires kde-runtime 4.8's declarative imports.
TODO:
. test right to left language support.
Screenshots
-----------
http://git.reviewboard.kde.org/r/103621/s/400/
New version with label accelerator working
http://git.reviewboard.kde.org/r/103621/s/407/
Thanks,
Lamarque Vieira Souza
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120130/b23818a0/attachment.htm>
More information about the kde-core-devel
mailing list